r00t2/gosecret
1
0
Fork 0
Code Issues Pull Requests Projects Releases Activity

I cannot create MR for some reason (Gitea hangs), but SetSecret needs a fix #1

New Issue
Closed
opened 2024-03-24 11:32:20 -04:00 by Ghost · 2 comments
Ghost commented 2024-03-24 11:32:20 -04:00
Copy Link
Copy Source

Fix: 92805347c3

Fix: https://git.square-r00t.net/lord/gosecret/commit/92805347c3eaf1de24954a005556bbbfa6ccaed6
bts commented 2024-04-30 10:58:22 -04:00
Owner
Copy Link
Copy Source

@lord Sorry! I completely missed notif on this.

Looks like there was a bug in the gitea version i was using, that should be fixed.

I'll have your fork merged in shortly and will close this issue when this occurs, thank you!

@lord Sorry! I completely missed notif on this. Looks like there was a bug in the gitea version i was using, that should be fixed. I'll have your fork merged in shortly and will close this issue when this occurs, thank you!
bts added the wontfix label 2024-04-30 11:12:47 -04:00
bts commented 2024-04-30 11:13:00 -04:00
Owner
Copy Link
Copy Source

Natch. It looks like you remove the adding of the actual secret.

https://pkg.go.dev/github.com/godbus/dbus/v5#Object.Call
https://git.r00t2.io/r00t2/gosecret/src/branch/master/consts.go#L157

Note that DbusItemSetSecret evaluates to the method org.freedesktop.Secret.Item.SetSecret, which as per upstream API docs requires a single argument, the secret to set.

If you can provide more information on why you think this fix is necessary, please re-open.

Closing, current status wontfix.

Natch. It looks like you remove the adding of the actual secret. https://pkg.go.dev/github.com/godbus/dbus/v5#Object.Call https://git.r00t2.io/r00t2/gosecret/src/branch/master/consts.go#L157 Note that `DbusItemSetSecret` evaluates to the method `org.freedesktop.Secret.Item.SetSecret`, which as per [upstream API docs](https://specifications.freedesktop.org/secret-service/latest/re03.html#org.freedesktop.Secret.Item.SetSecret) requires a single argument, the secret to set. If you can provide more information on why you think this fix is necessary, please re-open. Closing, current status wontfix.
bts closed this issue 2024-04-30 11:13:00 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels wontfix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bts (brent s.)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: r00t2/gosecret#1